-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add sourcery assistant review workflow #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Type: Enhancement
Summary of PR: This PR adds a GitHub Actions workflow to trigger Sourcery Coding Assistant reviews on pull requests when a review is requested or a specific label is added.
General PR suggestions
- Ensure that the GitHub secret
SOURCERY_TOKEN
is properly set up in the repository settings. - Verify that the
sourcery-nightly
package is the desired choice over the stable version for the project's needs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Type: Enhancement
Summary of PR: This PR adds a GitHub Actions workflow to trigger Sourcery Coding Assistant reviews on pull requests when a review is requested or a specific label is added.
General PR suggestions
- Ensure that the Sourcery token is securely stored and has the correct permissions.
- Verify that the triggers for the workflow align with the team's development workflow and practices.
- Consider specifying a version for the
sourcery-nightly
package to avoid potential issues with breaking changes in future nightly releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Type: Enhancement
Summary of PR: This PR adds a GitHub Actions workflow to trigger Sourcery Coding Assistant reviews on pull requests when a review is requested or the "sourcery-review" label is added.
General PR suggestions
- Ensure that the GitHub secret
SOURCERY_TOKEN
is properly set up in the repository settings. - Verify that the
sourcery-nightly
package is the desired choice over the stable version for the project's needs.
In particular there are a couple of runs that check permissions work allow the workflow to succeed:
This is even with restricted
GITHUB_TOKEN
permissions: