Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor shard name logic #878

Conversation

stefanhengl
Copy link
Member

We had 2 copies of this logic in the code and this bit me when I introduced id-based shards

indexbuilder.go seems an "ok" place to put the new function.
We cannot put it in the shards package because of circular dependencies.

Test plan:
refactor, so relying on CI

We had 2 copies of this logic in the code and this bit me when I
introduced id-based shards

indexbuilder.go seems an "ok" place to put. We cannot put it in the
shards package because of circular dependencies.

Test plan:
refactor, so relying on CI
@cla-bot cla-bot bot added the cla-signed label Dec 13, 2024
@stefanhengl stefanhengl requested a review from a team December 13, 2024 12:46
@stefanhengl stefanhengl marked this pull request as ready for review December 13, 2024 12:46
Copy link
Member

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor.

build/builder.go Outdated Show resolved Hide resolved
Copy link
Member

@keegancsmith keegancsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels like we should tighten up the exported api in the root zoekt pkg and move some stuff like this into an internal pkg. But looks good to land now :)

@stefanhengl stefanhengl merged commit dc1b23b into main Dec 18, 2024
10 checks passed
@stefanhengl stefanhengl deleted the stefan-splf-702-zoekt-refactor-shard-naming-logic-for-merging-and-zoekt branch December 18, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants