tenant: don't log missing tenant for watchdog #875
Conversation
yup, we could do that too. I don't mind either. Any reason to prefer one over the other? |
There was a problem hiding this comment.
Is it the case that when MT is enabled, watchdog will not actually search any data because there's no tenant in context? So it's not actually doing its 'watching' as originally intended. This same endpoint is used for k8 healthz monitoring. If I'm understanding right, it seems like we should update this to actually search some data!
Yes and no. It will trigger a proper search and trigger the full pipeline but it won't find anything. If we want to return results we either have to impersonate an existing tenant or give it system privileges to search across tenants. There is also the option to ship Zoekt with a dummy index belonging to tenant 1, but we would have to filter results from this repo for normal searches and make sure the index isn't cleaned up. |
This is an alternative to #875. We run the health check with system priviledges. This way we run an actual search, just like we do if tenant enforcement is off. I also make sure we don't log system searches as "missing_tenant".
This is an alternative to #875. We run the health check with system priviledges. This way we run an actual search, just like we do if tenant enforcement is off. I also make sure we don't log system searches as "missing_tenant".
This is an alternative to #875. We run the health check with system priviledges. This way we run an actual search, just like we do if tenant enforcement is off. I also make sure we don't log system searches as "missing_tenant".
|
Closing this in favor of #877 |
I suspect that most if not all of the "missing_tenant" profiles we see come from watchdog.
Here we add the same
skipLoggingmarker we use in Sourcegraph.