chore: remove unused feature "document ranks" #842
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document ranks was an experimental feature that allowed Zoekt to query Sourcegraph for additional ranking signals for files at index-time. We have decided to remove this feature because it was never used in production. Note: Most of the changes are Sourcegraph specific. However there are some exported fields in `SearchOptions` and `build.Options` as well as flags for zoekt-git-index which I simply removed. Test plan: updated tests
stefanhengl
commented
Oct 1, 2024
| @@ -13,9 +13,6 @@ service ZoektConfigurationService { | |||
| // List returns the list of repositories that the client should index. | |||
| rpc List(ListRequest) returns (ListResponse) {} | |||
|
|
|||
| // DocumentRanks returns the rank vectors for all documents in the specified repository. | |||
| rpc DocumentRanks(DocumentRanksRequest) returns (DocumentRanksResponse) {} | |||
There was a problem hiding this comment.
This has not been called for a long time, so it should be save to remove.
stefanhengl
commented
Oct 1, 2024
Comment on lines
-46
to
-47
| offlineRanking := flag.String("offline_ranking", "", "the name of the file that contains the ranking info.") | ||
| offlineRankingVersion := flag.String("offline_ranking_version", "", "a version string identifying the contents in offline_ranking.") |
There was a problem hiding this comment.
This is backward incompatible but I believe it's very unlikely that anyone used this outside Sourcegraph.
jtibshirani
approved these changes
Oct 1, 2024
jtibshirani
reviewed
Oct 1, 2024
| @@ -386,11 +386,6 @@ nextFileMatch: | |||
| // Update stats based on work done during document search. | |||
| updateMatchTreeStats(mt, &res.Stats) | |||
|
|
|||
| // If document ranking is enabled, then we can rank and truncate the files to save memory. | |||
| if opts.UseDocumentRanks { | |||
There was a problem hiding this comment.
This seems weird to me. Can't we always sort and truncate the files here?
|
closing this in favor of #853 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document ranks was an experimental feature that allowed Zoekt to query Sourcegraph for additional ranking signals for files at index-time. We have decided to remove this feature because it was never used in production.
Note:
Most of the changes are Sourcegraph specific. However there are some exported fields in
SearchOptionsandbuild.Optionsas well as flags for zoekt-git-index which I simply removed. I believe it is fairly unlikely that those were used by anyone outside Sourcegraph.Test plan:
updated tests