Remove branchMap in prepareNormalBuild #838
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the "build preparation" code to remove
branchMap
, in favor of storing everything in a single map. The main motivation is just to make the code clearer.Specific changes:
branchMap
BlobIndexInfo
to hold the old location information, plus branchesBlobLocation
->BlobRepo
To check there's no regression, I aadded a new benchmark
BenchmarkPrepareNormalBuild
. It shows small decrease in allocations:Baseline vs. PR