Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive: use ModTime as proxy for LatestCommitDate #836

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

stefanhengl
Copy link
Member

@stefanhengl stefanhengl commented Sep 26, 2024

This is motivated by #832

We use archive index in our e2e tests. In order to test our latest improvements to ranking, archive index needs to set the latest commit date.

Test plan:

  • new unit test
  • I checked that the tar files downloaded from github have the correct mod time.

This motivated by (add link here)

We use archive index in our e2e tests. In order to test our latest
improvements to ranking, archive index needs to set the latest commit
date.

Test plan:
- new unit test
- I checked the tar files downloaded from github have the correct mod time.
@cla-bot cla-bot bot added the cla-signed label Sep 26, 2024
@stefanhengl stefanhengl requested a review from a team September 26, 2024 14:02
@stefanhengl stefanhengl marked this pull request as ready for review September 26, 2024 14:03
@stefanhengl stefanhengl merged commit 64f1ad8 into main Sep 27, 2024
9 checks passed
@stefanhengl stefanhengl deleted the sh/archive-mod-time branch September 27, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants