Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the minimum compatible index version #824

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −19
Draft

Bump the minimum compatible index version #824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions read.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,24 +150,6 @@ func (r *reader) readTOC(toc *indexTOC) error {
}
}
}
} else {
// TODO: Remove this branch when ReaderMinFeatureVersion >= 10

secs := toc.sections()

if len(secs) != int(sectionCount) {
secs = toc.sectionsNext()
}

if len(secs) != int(sectionCount) {
return fmt.Errorf("section count mismatch: got %d want %d", sectionCount, len(secs))
}

for _, s := range secs {
if err := s.read(r); err != nil {
return err
}
}
}
return nil
}
Expand Down
2 changes: 1 addition & 1 deletion toc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ const WriteMinFeatureVersion = 10

// ReadMinFeatureVersion constrains backwards compatibility by refusing to
// load a file with a FeatureVersion below it.
const ReadMinFeatureVersion = 8
const ReadMinFeatureVersion = 10

// 17: compound shard (multi repo)
const NextIndexFormatVersion = 17
Expand Down
Loading