Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling numContextLines in non-json format #796

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

po3rin
Copy link
Contributor

@po3rin po3rin commented Jul 27, 2024

This PR makes NumContextLines available in formats other than json.

Why

Currently, I want to run my own search UI template on zoekt-webserver. However, since NumContextLines is only available in json format, I cannot use that information in my own template.

Please let us know what do you think. Thank you!

Copy link

cla-bot bot commented Jul 27, 2024

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Hiromu Nakamura.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@po3rin po3rin force-pushed the num-context-lines-in-non-json branch from e760c7b to d08ab91 Compare July 27, 2024 15:19
Copy link

cla-bot bot commented Jul 27, 2024

We require contributors to sign our Contributor License Agreement (CLA), and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added.

Sourcegraph teammates should refer to Accepting contributions for guidance.

@cla-bot cla-bot bot added the cla-signed label Jul 28, 2024
Copy link
Member

@keegancsmith keegancsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@keegancsmith keegancsmith merged commit 04e7057 into sourcegraph:main Jul 29, 2024
9 checks passed
@po3rin
Copy link
Contributor Author

po3rin commented Jul 29, 2024

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants