Rename UseKeywordScoring to mention BM25 #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fuzz test failed on commit 761bd1f. To troubleshoot locally, use the GitHub CLI to download the seed corpus with |
mmanela
reviewed
May 7, 2024
mmanela
approved these changes
May 7, 2024
keegancsmith
reviewed
May 8, 2024
| // Currently, this treats each match in a file as a term and computes an approximation to BM25. | ||
| // When enabled, all other scoring signals are ignored, including document ranks. | ||
| bool use_keyword_scoring = 15; | ||
| bool use_bm25_scoring = 15; |
There was a problem hiding this comment.
@ggilmore is it safe to rename this field in the proto file? Don't know enough about grpc :) I'm assuming yes since the type didn't change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's confusing to call this
UseKeywordScoring, since we do not use it for thekeywordpatterntype in Sourcegraph. This commit clarifies the name to mentionBM25.