zoekt-mirror-gerrit: allow to use reponame without host in the index #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keegancsmith
requested changes
Apr 29, 2024
There was a problem hiding this comment.
This is quite specific behaviour. Additionally I'm surprised at the amount of code for a private implementation detail for flag parsing. So I recommend one of the possible paths forward:
- take in a template and use go's text/template to generate the name.
- simplify how you parse the flag. Rather than a flag.Var, just use flag.String and handle unexpected outputs after calling flag.Parse
cmd/zoekt-mirror-gerrit/main.go
Outdated
| func main() { | ||
| dest := flag.String("dest", "", "destination directory") | ||
| namePattern := flag.String("name", "", "only clone repos whose name matches the regexp.") | ||
| // Default value for | ||
| repoFormat := WithServerHost | ||
| flag.Var(&RepoFormatEnumValue{&repoFormat}, "repo-name-format", "the format of the local repo name in zoekt (WithServerHost or WithoutServerHost)") |
There was a problem hiding this comment.
minor: the CamelCase values read a bit weird for a command line argument. Maybe better values for this would be qualified and project?
The repo is indexed only with the reponame which is more user-friendly in the search when there is onely one host Filter string will be "r:my-repo" instead of "r:my-gerrit-sever.com/my-repo"
xavier-calland
force-pushed
the
gerrit-repo-name
branch
from
f43b96f to
7cb5d16
Compare
keegancsmith
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repo is indexed only with the reponame which is more user-friendly in the search when there is onely one host
Filter string will be "r:my-repo" instead of "r:my-gerrit-sever.com/my-repo"