Don't truncate file before detecting language #740
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we truncate a file's contents to 2048 bytes before passing it to
go-enry
. I ran into a few cases where this is causing us to misclassifyfiles.
This PR removes the truncation. It should still be fine in terms of
performance, since
go-enry
is quite fast in general: ~1ms in my localtesting, even for large files. And we only run language detection if we plan to
index the file, which means we skip binary files and large files.