sourcegraph: Remove HTTP APIs #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer serve these old HTTP APIs starting with Sourcegraph 5.3, so this code is no longer required. I hope this makes your lives a little easier by not having to maintain two code paths. If this change is annoying (because you cannot backport fixes to older versions as easily), feel free to either keep it on hold or close it. ## Test plan CI still passes, anything else I should be trying?
eseliger
requested review from
jtibshirani,
keegancsmith,
ggilmore and
stefanhengl
and removed request for
jtibshirani
keegancsmith
approved these changes
Feb 5, 2024
| @@ -108,11 +108,6 @@ var ( | |||
| Help: "Number of indexed repos by code host", | |||
| }) | |||
|
|
|||
| metricNumAssigned = promauto.NewGauge(prometheus.GaugeOpts{ | |||
There was a problem hiding this comment.
heh, seems this wasn't used. I wonder when we regressed on that.
| return shouldRetry, checkErr | ||
| } | ||
|
|
||
| func newSourcegraphClient(rootURL *url.URL, hostname string, grpcClient proto.ZoektConfigurationServiceClient, opts ...SourcegraphClientOption) *sourcegraphClient { |
There was a problem hiding this comment.
kinda weird we pass in the rootURL but the caller of this function needs to dial grpc and pass that client in. Can we instead make it so this function does the dialing and maybe then returns an error?
There was a problem hiding this comment.
hmm we can, but that makes testing a bit harder because you can't as easily feed in a mocked grpc client 🤔 WDYT about that?
jtibshirani
approved these changes
Feb 5, 2024
ggilmore
approved these changes
Feb 7, 2024
stefanhengl
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer serve these old HTTP APIs starting with Sourcegraph 5.3, so this code is no longer required.
I hope this makes your lives a little easier by not having to maintain two code paths.
If this change is annoying (because you cannot backport fixes to older versions as easily), feel free to either keep it on hold or close it.
Test plan
CI still passes, anything else I should be trying?