Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gomod: update otel and circl for CVEs #737

Merged
merged 1 commit into from
Feb 2, 2024
Merged

gomod: update otel and circl for CVEs #737

merged 1 commit into from
Feb 2, 2024

Conversation

keegancsmith
Copy link
Member

This updates two of our dependencies to resolve GHSA-9763-4f94-gfch and CVE-2023-47108.

Initially I ran

go get \
  go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/[email protected] \
  github.com/cloudflare/[email protected]

But then "go mod tidy" failed since otel likes to refactor and rename things for not much benefit to end users. I tried a few different things to get it to work, but finally just updated all otel deps to the latest version:

go get -u go.opentelemetry.io/otel/...

Test Plan: unit tests, "go mod tidy" is clean and "trivy fs go.mod" reports no vulns.

This updates two of our dependencies to resolve GHSA-9763-4f94-gfch and
CVE-2023-47108.

Initially I ran

  go get \
    go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/[email protected] \
    github.com/cloudflare/[email protected]

But then "go mod tidy" failed since otel likes to refactor and rename
things for not much benefit to end users. I tried a few different things
to get it to work, but finally just updated all otel deps to the latest
version:

  go get -u go.opentelemetry.io/otel/...

Test Plan: unit tests, "go mod tidy" is clean and "trivy fs go.mod"
reports no vulns.
@keegancsmith keegancsmith requested review from willdollman and a team February 2, 2024 11:01
@keegancsmith keegancsmith merged commit 245e0ce into main Feb 2, 2024
8 checks passed
@keegancsmith keegancsmith deleted the k/vuln-again branch February 2, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants