api: JSON omitempty on optional fields in FileMatch #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several fields which are optional in FileMatch. For example branch and version are only set if indexing a git repo (zoekt can index arbitrary files). We mark these fields as optional to marshal in JSON. The main benefit of this is improving the readability of some golden files. Note: I noticed this when an unrelated commit touched these golden files. Test Plan: go test
jtibshirani
approved these changes
Jan 17, 2024
Yeah it looks pretty minimal to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are several fields which are optional in FileMatch. For example branch and version are only set if indexing a git repo (zoekt can index arbitrary files). We mark these fields as optional to marshal in JSON. The main benefit of this is improving the readability of some golden files.
Note: I noticed this when an unrelated commit touched these golden files.
Test Plan: go test