revert use of mmap-go #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a suspicion that when we switched to using the mmap-go library it contributed to an issue where zoekt-webserver stops responding on some linux versions. Our suspicion has something to do from us hardcoding the page size to 4k to asking the kernel and how that interacts with THP. Given we don't actually build for windows anymore, we are partially reverting the mmap changes from 7424ac8 Test Plan: go test ./... on darwin. Then CI for linux testing.
|
cc @peterguy |
jtibshirani
approved these changes
Nov 29, 2023
keegancsmith
added a commit
that referenced
this pull request
Nov 29, 2023
We have a suspicion that when we switched to using the mmap-go library it contributed to an issue where zoekt-webserver stops responding on some linux versions. Our suspicion has something to do from us hardcoding the page size to 4k to asking the kernel and how that interacts with THP. Given we don't actually build for windows anymore, we are partially reverting the mmap changes from 7424ac8 Test Plan: go test ./... on darwin. Then CI for linux testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a suspicion that when we switched to using the mmap-go library it contributed to an issue where zoekt-webserver stops responding on some linux versions. Our suspicion has something to do from us hardcoding the page size to 4k to asking the kernel and how that interacts with THP. Given we don't actually build for windows anymore, we are partially reverting the mmap changes from
7424ac8
Test Plan: go test ./... on darwin. Then CI for linux testing.