Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gomod: require go1.21 #705

Merged
merged 1 commit into from
Nov 29, 2023
Merged

gomod: require go1.21 #705

merged 1 commit into from
Nov 29, 2023

Conversation

keegancsmith
Copy link
Member

This will allow us to use the new builtins.

Test Plan: go test ./... and CI

@keegancsmith
gomod: require go1.21
b377200 
This will allow us to use the new builtins.

Test Plan: go test ./... and CI
@keegancsmith keegancsmith requested a review from a team November 29, 2023 08:58
jtibshirani
jtibshirani approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty big bump (1.18 -> 1.21), will be interesting if we see effects on performance.

@keegancsmith
Copy link
Member Author

This is a pretty big bump (1.18 -> 1.21), will be interesting if we see effects on performance.

This declares the minimum version of go we support. In practice we deploy with the latest release so unlikely we will notice anything major in production.

@keegancsmith keegancsmith merged commit 8abf874 into main Nov 29, 2023
8 checks passed
@keegancsmith keegancsmith deleted the k/go1.21 branch November 29, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtibshirani jtibshirani jtibshirani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@keegancsmith @jtibshirani