ctags: require scip-ctags to be present #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
jtibshirani
force-pushed
the
jtibs/ctags
branch
from
9dbf226 to
3b26bd5
Compare
jtibshirani
force-pushed
the
jtibs/ctags
branch
from
3b26bd5 to
485e273
Compare
keegancsmith
approved these changes
Nov 17, 2023
| // this happens if CTagsMustSucceed is not true and we didn't find universal-ctags | ||
| continue | ||
| } | ||
| // this happens if CTagsMustSucceed is false and we didn't find the binary |
There was a problem hiding this comment.
I can't believe I wrote "not true" instead of "false" in the old code comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we didn't require that scip-ctags be available even if if you set
require_ctagsand setlanguage_mapto something likego:scip. Instead, wesilently fell back to
universal-ctags. This is tricky and could mask a realissue where we expect scip-ctags to be available but it isn't.
Now, we check if SCIP is needed based on
language_map, and if so require thatscip-ctags is available.
Test plan
Lots of manual testing with various combinations of
language_mapandrequire_ctags. Also hooked up this change tosg startand checked indexingworks well.