matchtree: always use evalMatchTree #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From reading the implementation recently I noticed that we should always go via evalMatchTree to ensure we correctly use the known map for caching. This updates the two call sites we didn't do this as well as documenting this requirement. I don't think this caused any noticeable performance issues. We would do slightly more work in the case the root matchTree was an and, but it would have been miniscule. Test Plan: go test
jtibshirani
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From reading the implementation recently I noticed that we should always go via evalMatchTree to ensure we correctly use the known map for caching. This updates the two call sites we didn't do this as well as documenting this requirement.
I don't think this caused any noticeable performance issues. We would do slightly more work in the case the root matchTree was an andMatchTree (or other multi children nodes), but it would have been miniscule.
Test Plan: go test