Indexing: improve skipped doc handling #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
keegancsmith
approved these changes
Nov 12, 2023
build/ctags.go
Outdated
| @@ -49,7 +49,7 @@ func ctagsAddSymbolsParserMap(todo []*zoekt.Document, languageMap ctags.Language | |||
| var tagsToSections tagsToSections | |||
|
|
|||
| for _, doc := range todo { | |||
| if doc.Symbols != nil { | |||
| if doc.Content == nil || doc.Symbols != nil { | |||
There was a problem hiding this comment.
nit: rather check that len(doc.Content) == 0. Means the same thing but you get the benefit of avoiding ctags for empty content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes a couple small improvements to how we handle skipped docs:
nilinvariant. And generally it's good for performance to group data that is
expected to be accessed together and has similar content.
Follow up to #686. I didn't see a nice opportunity for a refactor and instead
fixed the obvious issues.