Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scoring: show atom count in debug score #669

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

stefanhengl
Copy link
Member

Tiny change to display the atom count in addition to the score. I caught myself several times trying to translate the score to an atom count.

Test plan:
Ran it locally
Screenshot 2023-10-20 at 15 36 15

Tiny change to display the atom count. I caught myself several times trying to
translate the score to an atom count.

Test plan:
Ran it locally
@stefanhengl stefanhengl requested a review from a team October 20, 2023 13:40
Copy link
Member

@keegancsmith keegancsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: we should adjust the addScore stuff to avoid allocating when debug is off. This line goes from not allocating to allocating a string.

@stefanhengl stefanhengl merged commit ca7ee51 into main Oct 23, 2023
7 of 8 checks passed
@stefanhengl stefanhengl deleted the sh/show-atom-count branch October 23, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants