score: clean up debug output #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit does the following to the debug output: - consistent fmt string for chunk and line matches - do not include in debug if 0 score - trim ", " suffix on final score string Test Plan: debug output is more succinct :)
stefanhengl
reviewed
Oct 19, 2023
| @@ -33,7 +33,7 @@ import ( | |||
| const maxUInt16 = 0xffff | |||
|
|
|||
| func (m *FileMatch) addScore(what string, s float64, debugScore bool) { | |||
| if debugScore { | |||
| if s != 0 && debugScore { | |||
There was a problem hiding this comment.
Not sure about this. s==0 means that we actually found a symbol kind but didn't give it a score, no? This seems useful to show because it points to gap in our scoring. How else would we figure out such a gap just by looking at the debug output?
There was a problem hiding this comment.
See my other or making us default to a factor of 1 for unknown symbols
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does the following to the debug output:
Test Plan: debug output is more succinct :)