fix off-by-one

sourcegraph · Apr 18, 2024 · e402c78 · e402c78
1 parent 40e86e5
commit e402c78
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/index_test.go b/index_test.go
@@ -3254,7 +3254,7 @@ func TestLineAnd(t *testing.T) {
 
 	t.Run("ChunkMatches", func(t *testing.T) {
 		res := searchForTest(t, b, &q, chunkOpts)
-		wantRegexpCount := 2 // TODO: justify this change
+		wantRegexpCount := 1
 		if gotRegexpCount := res.RegexpsConsidered; gotRegexpCount != wantRegexpCount {
 			t.Errorf("got %d, wanted %d", gotRegexpCount, wantRegexpCount)
 		}

diff --git a/matchtree.go b/matchtree.go
@@ -726,12 +726,12 @@ nextLine:
 					children[j] = children[j][1:]
 					continue nextCandidate
 				}
-				if bo <= lines[i].end {
+				if bo < lines[i].end {
 					hits++
 					continue nextChild
 				}
-				// move the `lines` iterator forward until bo <= line.end
-				for i < len(lines) && bo > lines[i].end {
+				// move the `lines` iterator forward until bo < line.end
+				for i < len(lines) && bo >= lines[i].end {
 					i++
 				}
 				i--