Skip to content

Commit

Permalink
Bump the minimum compatible index version
Browse files Browse the repository at this point in the history
  • Loading branch information
jtibshirani committed Sep 13, 2024
1 parent 44eab0c commit 23758cb
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 19 deletions.
18 changes: 0 additions & 18 deletions read.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,24 +150,6 @@ func (r *reader) readTOC(toc *indexTOC) error {
}
}
}
} else {
// TODO: Remove this branch when ReaderMinFeatureVersion >= 10

secs := toc.sections()

if len(secs) != int(sectionCount) {
secs = toc.sectionsNext()
}

if len(secs) != int(sectionCount) {
return fmt.Errorf("section count mismatch: got %d want %d", sectionCount, len(secs))
}

for _, s := range secs {
if err := s.read(r); err != nil {
return err
}
}
}
return nil
}
Expand Down
2 changes: 1 addition & 1 deletion toc.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ const WriteMinFeatureVersion = 10

// ReadMinFeatureVersion constrains backwards compatibility by refusing to
// load a file with a FeatureVersion below it.
const ReadMinFeatureVersion = 8
const ReadMinFeatureVersion = 10

// 17: compound shard (multi repo)
const NextIndexFormatVersion = 17
Expand Down

0 comments on commit 23758cb

Please sign in to comment.