Skip to content

Commit

Permalink
Shadow the error to prevent the error being returned later on
Browse files Browse the repository at this point in the history
  • Loading branch information
Piszmog committed Aug 7, 2023
1 parent 7bbdd39 commit 26f02f2
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmd/src/batch_common.go
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ func executeBatchSpec(ctx context.Context, opts executeBatchSpecOpts) (err error
}
if hasWorkspaceFiles {
execUI.UploadingWorkspaceFiles()
if err = svc.UploadBatchSpecWorkspaceFiles(ctx, batchSpecDir, string(id), batchSpec.Steps); err != nil {
if err := svc.UploadBatchSpecWorkspaceFiles(ctx, batchSpecDir, string(id), batchSpec.Steps); err != nil {
// Since failing to upload workspace files should not stop processing, just warn
execUI.UploadingWorkspaceFilesWarning(errors.Wrap(err, "uploading workspace files"))
} else {
Expand Down

0 comments on commit 26f02f2

Please sign in to comment.