This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
go.mod: bump zoekt #62332
Merged
go.mod: bump zoekt #62332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes the following changes - 783a51a784 docker: use go1.22 and alpine3.19 - 301c735b9c docker: fix typo in builder name - a0f051e95e all: remove gob and SSE rpc endpoints - 8619902b5d gitindex: include environ for git tests - 55b7aeee2d docker: simplify apk add lines - 734f5b64f8 gomod: update deps for CVE-2023-45288 and CVE-2024-24786 - 6df055493b gitindex: interpret SSH URLs - 5ecbc14cac zoekt-indexserver: prune branches on fetch - 5411e9b32e zoekt-mirror-gerrit: allow to use reponame without host in the index - 570757e20b Honor regex flags for case-sensitivity - 68d04651cc zoekt-mirror-gerrit: handle http authentication - 72f95004e6 fix: don't modify finalCands Test plan: Zoekt CI
github-actions
bot
added
team/product-platform
team/search-platform
stefanhengl
commented
May 1, 2024
| @@ -96,14 +96,6 @@ func (m *meteredSearcher) StreamSearch(ctx context.Context, q query.Q, opts *zoe | |||
| tr, ctx := trace.New(ctx, "zoekt."+cat, attrs...) | |||
| defer tr.EndWithErrIfNotContext(&err) | |||
|
|
|||
| // We wrap our queries in GobCache, this gives us a convenient way to find | |||
| // out the marshalled size of the query. | |||
| if gobCache, ok := q.(*query.GobCache); ok { | |||
There was a problem hiding this comment.
We don't wrap our queries in GobCache anymore since we fully switched to grpc, see here
keegancsmith
approved these changes
May 1, 2024
jtibshirani
approved these changes
May 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a couple of changes we should roll out with the upcoming release. I had to update Sourcegraph too, see PR description of zoekt/#758.
Test plan:
Zoekt CI