This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
gomod: update zoekt to remove perf regression in go 1.22 #61515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates zoekt to have one more commit. See details of commit for more information. sourcegraph/zoekt@8cf8887...c39011a - c39011a141 all: use a faster vendored regexp/syntax/Regexp.String Test Plan: CI
github-actions
bot
added
team/product-platform
team/search-platform
burmudar
approved these changes
Apr 2, 2024
Some tests hardcode the output of zoekt's query to string. The last commit made use use the regex format from go1.21. This updates those values to use them. Additionally we switch a test to using autogold so that when we have correctly workedaround this in the future updating will be easy. Test Plan: CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates zoekt to have one more commit. See details of commit for more information.
sourcegraph/zoekt@8cf8887...c39011a
Test Plan: CI
Part of https://github.com/sourcegraph/sourcegraph/issues/61462