This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
Search: solidify conversion to Zoekt queries #60349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jtibshirani
commented
Feb 9, 2024
internal/search/zoekt/query.go
Outdated
| func toLangFilters(langs []string) []zoekt.Q { | ||
| var filters []zoekt.Q | ||
| for _, lang := range langs { | ||
| lang, _ = enry.GetLanguageByAlias(lang) // Invariant: lang is valid. |
There was a problem hiding this comment.
I know Go doesn't have built-in assertions and it's documented why, but I think it would be helpful to assert that the second return value is true to catch potential bugs.
There was a problem hiding this comment.
By "assert" do you mean check the value and return an error? Unfortunately that makes this quite verbose and less readable. For "runtime assertions", do we ever use panic? I haven't seen this used in our Go code, maybe it goes against the spirit of Go's design.
For now I didn't touch this (as it's a pre-existing issue) but would be interested in your thoughts!
varungandhi-src
approved these changes
Feb 9, 2024
jtibshirani
commented
Feb 9, 2024
stefanhengl
approved these changes
Feb 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the 'search-content-based-lang-detection' feature, this PR improves how filters are converted to Zoekt queries:
-lang:goRelates to https://github.com/sourcegraph/sourcegraph/issues/60341
Test plan
Added new unit tests, manual testing