Only install coursier and sbt in docker container #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val _ = assembly.value | ||
| IO.copyFile(fatJar, slimJar, CopyOptions().withOverwrite(true)) | ||
| slimJar | ||
| assembly.value |
There was a problem hiding this comment.
I squinted hard at this and I feel like copying is not necessary, as the actual path to the jar doesn't matter.
My hunch is that for some reason copying causes issues (sbt/io#371) which result in flaky CI.
Tests all seem green as well, so I doubt there's a change in published artifacts. Will check the snapshot deployment on maven central to confirm jars are still usable.
olafurpg
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default coursier preinstalls some applications which aren't necessary, and can cause issues with local setup.
We limit that to just coursier itself and sbt
Test plan