Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also support Java 21 #743

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Also support Java 21 #743

merged 1 commit into from
Sep 12, 2024

Conversation

madorb
Copy link
Contributor

@madorb madorb commented Aug 30, 2024

Test plan

  • run sbt docker and ensure image builds
  • inspect image to ensure it contains jdk 21

Errors

Unfortunately i couldn't get this to work, due to what i assume is a local configuration problem. That said, i believe this change should be safe as i exactly copied previous patterns.

When running ./sbt then docker i received the following

...
[info] #9 14.44 Downloaded 66 missing file(s) / 66
[info] #9 15.02 Checking if a JVM is installed
[info] #9 15.02 Found a JVM installed under /opt/java/openjdk.
[info] #9 15.02
[info] #9 15.02 Checking if ~/.local/share/coursier/bin is in PATH
[info] #9 15.02 Should we add ~/.local/share/coursier/bin to your PATH via ~/.profile? [Y/n] Y
[info] #9 15.02
[info] #9 15.02 Checking if the standard Scala applications are installed
  Installed ammonite
  Installed cs
  Installed coursier
No prebuilt binary available at https://github.com/scala/scala3/releases/download/3.5.0/scala3-3.5.0-aarch64-pc-linux.tar.gz, https://github.com/scala/scala3/releases/download/3.4.3/scala3-3.4.3-aarch64-pc-linux.tar.gz, https://github.com/scala/scala3/releases/download/3.4.2/scala3-3.4.2-aarch64-pc-linux.tar.gz, https://github.com/scala/scala3/releases/download/3.4.1/scala3-3.4.1-aarch64-pc-linux.tar.gz, https://github.com/scala/scala3/releases/download/3.4.0/scala3-3.4.0-aarch64-pc-linux.tar.gz
[info] #9 ERROR: process "/bin/sh -c ./docker-setup.sh" did not complete successfully: exit code: 1
[info] ------
[info]  > [ 5/12] RUN ./docker-setup.sh:
[info] 11.13 Downloaded 62 missing file(s) / 66
[info] 11.13 Downloaded 63 missing file(s) / 66
[info] 11.42 Downloaded 64 missing file(s) / 66
[info] 11.66 Downloaded 65 missing file(s) / 66
[info] 14.44 Downloaded 66 missing file(s) / 66
[info] 15.02 Checking if a JVM is installed
         Installed ammonite
[info]   Installed cs
No prebuilt binary available at https://github.com/scala/scala3/releases/download/3.5.0/scala3-3.5.0-aarch64-pc-linux.tar.gz, https://github.com/scala/scala3/releases/download/3.4.3/scala3-3.4.3-aarch64-pc-linux.tar.gz, https://github.com/scala/scala3/releases/download/3.4.2/scala3-3.4.2-aarch64-pc-linux.tar.gz, https://github.com/scala/scala3/releases/download/3.4.1/scala3-3.4.1-aarch64-pc-linux.tar.gz, https://github.com/scala/scala3/releases/download/3.4.0/scala3-3.4.0-aarch64-pc-linux.tar.gz
[info] ------
[info] Dockerfile:8
[info] --------------------
[info]    6 |
[info]    7 |     COPY ./bin/docker-setup.sh .
[info]    8 | >>> RUN ./docker-setup.sh
[info]    9 |
[info]   10 |
[info] --------------------
[info] ERROR: failed to solve: process "/bin/sh -c ./docker-setup.sh" did not complete successfully: exit code: 1
[info] View build details: docker-desktop://dashboard/build/desktop-linux/desktop-linux/k91oxlknsaiwk6i2wjh56yvmr
[error] stack trace is suppressed; run last cli / docker for the full output
[error] (cli / docker) sbtdocker.DockerBuildException: Failed to build Docker image (exit code: 1)
[error] Total time: 82 s (01:22), completed Aug 30, 2024, 3:05:04 PM```

@antonsviridov-src
Copy link
Contributor

Hey @madorb, apologies for missing this – something wrong with my notifications.
Let me see what'sup.

@antonsviridov-src antonsviridov-src merged commit ca095a4 into sourcegraph:main Sep 12, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants