Fix trailing SBT args and add tests #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynmol
commented
Sep 25, 2023
| @@ -43,8 +43,14 @@ class SbtBuildTool(index: IndexCommand) extends BuildTool("sbt", index) { | |||
|
|
|||
| private def unconditionallyGenerateScip(): Int = | |||
| Using.resource(sourcegraphSbtPluginFile()) { _ => | |||
| val buildCommand = | |||
| if (index.buildCommand.isEmpty) | |||
| List("sourcegraphScip") | |||
There was a problem hiding this comment.
@olafurpg what's the approach to custom build commands?
sourcegraphScip only produces the SCIP file itself, do we leave it as the last command anyways, or expect the user to add it in if they need the SCIP index as well?
There was a problem hiding this comment.
To mirror the Maven/Gradle behavior, the user should only provide commands to compile the codebase to generate SemanticDB
varungandhi-src
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #650
Test plan