Special handling of Bazel with source generators #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Handle path with filename separated by : - Detect javac' source generation root - Not include semanticdb files for auto-generated files
olafurpg
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original issue was reported by a customer on a private codebase, and amounted to the usage of source generators crashing the javac plugin because the inferred sourceroot didn't match the location where Bazel spits out files generated by annotation processors.
By sheer luck, @ciarand in #600 was working through the same issues.
This PR makes the handling of those scenarios more robust and adds a reduced form of the problematic setup to the bazel example, so that it runs on CI
:Test plan
I verified that the SCIP index produced contains both examples, and doesn't contain documents for generated code
