Migrate autocomplete related protocol to the generated protocol #2584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkondratek
force-pushed
the
mkondratek/chore/migrate-to-protocol
branch
2 times, most recently
from
685b395
to
75b6ee3
Compare
mkondratek
added a commit
to sourcegraph/cody
that referenced
this pull request
Nov 6, 2024
…6073) Previously, CompletionBookkeepingEvent fields that represent timestamp could be floating numbers (non-integer). That was breaking type deserialization in the JetBrains client (and likely could cause troubles in other clients). The protocol expects integers. This PR ensures that the timestamps are integers. ## Test plan Tested manually with sourcegraph/jetbrains#2584. <!-- Required. See https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles. --> ## Changelog <!-- OPTIONAL; info at https://www.notion.so/sourcegraph/Writing-a-changelog-entry-dd997f411d524caabf0d8d38a24a878c -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test plan