Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove potential infinite init loop #2577

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Conversation

mkondratek
Copy link
Contributor

@mkondratek mkondratek commented Nov 4, 2024

Accidentally, I found an infinite loop in cody tool window content initialization. It was likely a reason of the recent CI failures. This PR eliminates the risk of the inifinite loop.

Test plan

  1. Run integrationTests locally - should be all green, no sus logs, or errros indicating a loop in call stack

@mkondratek mkondratek self-assigned this Nov 4, 2024
@@ -39,6 +40,10 @@ public void createToolWindowContent(@NotNull Project project, @NotNull ToolWindo
}

toolWindow.setAdditionalGearActions(customCodySettings);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mkondratek mkondratek merged commit bc926d1 into main Nov 4, 2024
6 checks passed
@mkondratek mkondratek deleted the mkondratek/fix/init-loop branch November 4, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants