Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable JCEF in integration tests #2144

Closed
wants to merge 3 commits into from
Closed

Conversation

mkondratek
Copy link
Contributor

@mkondratek mkondratek commented Aug 28, 2024

Test plan

  1. IntelliJ does not complain about the env variable being "false"

@mkondratek mkondratek self-assigned this Aug 28, 2024
@mkondratek mkondratek marked this pull request as draft August 28, 2024 09:55
build.gradle.kts Outdated
@@ -226,7 +226,7 @@ fun Test.sharedIntegrationTestConfig(buildCodyDir: File, mode: String) {
"CODY_TELEMETRY_EXPORTER" to "testing",
// Fastpass has custom bearer tokens that are difficult to record with Polly
"CODY_DISABLE_FASTPATH" to "true",
)
"ide.browser.jcef.headless.enabled" to "true")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it still complains... 🤔

[   6779]   WARN - #c.i.u.j.JBCefApp - JCEF is manually disabled in headless env via 'ide.browser.jcef.headless.enabled=false'

Copy link
Contributor

@dominiccooney dominiccooney Aug 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these are environment variables, but Registry properties?

com. intellij. openapi. util. registry.Registry.get("ide.browser.jcef.headless.enabled").setValue("true") something like that...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dominic. I tried setting this in the test setup. Something goes wrong in the test execution in CI. I have no time to focus on it now. Hopefully, I will get back to it later this week.

@mkondratek mkondratek force-pushed the mkondratek/chore/jcef-in-ci branch 2 times, most recently from 2e3385d to 0a27f4d Compare September 16, 2024 07:15
@mkondratek
Copy link
Contributor Author

won't fix. we are going to switch to the other integration tests anyway

@mkondratek mkondratek closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants