-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable JCEF in integration tests #2144
Conversation
0438ed1
to
0cefb03
Compare
build.gradle.kts
Outdated
@@ -226,7 +226,7 @@ fun Test.sharedIntegrationTestConfig(buildCodyDir: File, mode: String) { | |||
"CODY_TELEMETRY_EXPORTER" to "testing", | |||
// Fastpass has custom bearer tokens that are difficult to record with Polly | |||
"CODY_DISABLE_FASTPATH" to "true", | |||
) | |||
"ide.browser.jcef.headless.enabled" to "true") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it still complains... 🤔
[ 6779] WARN - #c.i.u.j.JBCefApp - JCEF is manually disabled in headless env via 'ide.browser.jcef.headless.enabled=false'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think these are environment variables, but Registry properties?
com. intellij. openapi. util. registry.Registry.get("ide.browser.jcef.headless.enabled").setValue("true")
something like that...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping @mkondratek
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Dominic. I tried setting this in the test setup. Something goes wrong in the test execution in CI. I have no time to focus on it now. Hopefully, I will get back to it later this week.
2e3385d
to
0a27f4d
Compare
0a27f4d
to
77885c5
Compare
won't fix. we are going to switch to the other integration tests anyway |
Test plan