Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Make code lens at block level and refactor FIxupSession #2058

Closed

Conversation

justinmilner1
Copy link

@justinmilner1 justinmilner1 commented Aug 19, 2024

THIS IS A DRAFT:
I can't get the most recent main branch to build to save my life! - and so can't test the Cody agent changes that are required for full functionality (reject all requires agent changes).
@umpox Do you know if anyone else has been experiencing challenges with building recently? If you're able to build, do you mind sending me the following?:

  • 'pnpm list' output
  • node version, pnpm version
  • If you're not using the ones checked into main - your package.json and pnpm-lock.yaml files
  • Anything else that might help!
    Thank you!!!

This PR is a follow up to this recently merged vscode PR.

Agent changes (DRAFT): Can be found here

Motivation: To enable code lens at the edit/block level.

While implementing this PR, FixupSession became far too convoluted and handled too broad a set of responsibilities - as a result I decided to break some logical groups into the new classes EditManager and LensGroupManager.

simplescreenrecorder-2024-08-18_20.00.38.mp4

@pkukielka
Copy link
Contributor

pkukielka commented Aug 19, 2024

Hey @justinmilner1 , I think you were on a bit old main when starting this branch.
I completely refactored the way fixups works couple of weeks ago:

#1955

FixupSession has been removed, and lens logic is now fully controlled by agent.

@justinmilner1
Copy link
Author

@pkukielka Ohhh man... yeah none of this is useful anymore...

I should've better communicated what I planned to build before starting - is there a chat, or similar, for open source contributors to engage with?

@justinmilner1
Copy link
Author

Obsoleted by recent changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants