Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run plugin verifier for 2024.2 and add INTERNAL_API_USAGES to the skipped failure levels #2010

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

mkondratek
Copy link
Contributor

@mkondratek mkondratek commented Aug 8, 2024

Removing the internal api usages is nontrivial task. It seems to be better to run the verifier skipping the internal api usages complaints than not running it at all for 242. Let's run it and skip the internal api usages errors. Eventually, we should try to eliminate them and remove the skipped failure level.

The follow-up task: https://linear.app/sourcegraph/issue/CODY-3202/jetbrains-do-not-use-internal-api

Test plan

  1. Green CI

@mkondratek mkondratek self-assigned this Aug 8, 2024
Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkondratek mkondratek enabled auto-merge (squash) August 8, 2024 11:59
@mkondratek mkondratek merged commit e7519e5 into main Aug 8, 2024
5 of 6 checks passed
@mkondratek mkondratek deleted the mkondratek/chore/run-plugin-verifier-for-242 branch August 8, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants