Ensure the rendered autocompletion is not empty (fixes #2003) #2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkukielka
reviewed
Aug 8, 2024
| @@ -434,6 +434,7 @@ class CodyAutocompleteManager { | |||
| if (lines.size > 1) { | |||
| val text = | |||
| (if (startsInline) lines.drop(1) else lines).dropWhile { it.isBlank() }.joinToString("\n") | |||
| if (text.isEmpty()) return | |||
There was a problem hiding this comment.
Shouldn't we also check for an empty line few line above?
completionText.lines().first(), items, editor, AutocompleteRendererType.INLINE)
There was a problem hiding this comment.
I believe the previous place is already assured by the check before:
if (completionText.trim().isBlank()) return
There was a problem hiding this comment.
whoops, sorry - you are right - I fixed the remaining cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CODY-3189
The check was originally there - we lost it at some point:
4f50796#diff-cb6c461805813f1dff589b6e691cded2a165241943810513c716325ad1fe25baR310
If the text to be rendered is empty let's skip the rendering.
Test plan
Hard to repro. Probably requires a python project.