Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call getAuthenticationState on a pooled thread instead of EDT #1996

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Call getAuthenticationState on a pooled thread instead of EDT #1996

merged 1 commit into from
Aug 7, 2024

Conversation

mkondratek
Copy link
Contributor

@mkondratek mkondratek commented Aug 7, 2024 •
edited
Loading

No need to call this method on EDT (at least not there).

Test plan

  1. runIde
  2. verify that the error does not appear in the logs

@mkondratek mkondratek self-assigned this Aug 7, 2024
pkukielka
pkukielka approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@pkukielka pkukielka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkukielka pkukielka merged commit 8edc00e into main Aug 7, 2024
9 of 10 checks passed
@pkukielka pkukielka deleted the mkondratek/fix/wrong-thread branch August 7, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkukielka pkukielka pkukielka approved these changes

Assignees

@mkondratek mkondratek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkondratek @pkukielka