CodeActions: Skip UI specific paths #1995
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
RXminuS
changed the title
RXminuS
changed the title
RXminuS
changed the title
Base automatically changed from
rnauta/cody-3166-sourcegraphjetbrains1991-jetbrains-ask-cody-to-fix-and-ask
to
main
August 7, 2024 11:12
|
@RXminuS Closing this one in place of https://github.com/sourcegraph/jetbrains/pull/1998/files |
pkukielka
added a commit
that referenced
this pull request
Aug 7, 2024
## Changes Replaces #1995 Fixes Fixes [CODY-3166](https://linear.app/sourcegraph/issue/CODY-3166/sourcegraphjetbrains1991-jetbrains-ask-cody-to-fix-and-ask-cody-to) / #1991 Mock files are used for in-memory buffers. Normally all editable code files are not mocks/in-memory files (even scratches are normal files) so we can assume if file is mock it is most likely some special component for which we do not want to add cody error highlighting. ## Test plan Manually verified that HighlightPass no longer applies to the Repo Editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before the Cody CodeHighlight pass would apply to all editors, including those used in a "hacky" way to create UI elements such as the repo-input field used in the Cody sidebar.
Now we explicitly ignore these fake file editors. Note that as a follow up we might need to consider that other extensions similarly "mis-use" editors in the same way we did and that ignoring our specific paths isn't a long-term solution.
Fixes CODY-3166 / #1991
Test plan
Manually verified that HighlightPass no longer applies to the Repo Editor