Put in some fixes for the new cody-highlights code path #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was throwing at least two exceptions, one reported by QA and one that I saw myself. The one I saw was that ProtocolTextDocument must be created on the EDT. I don't really know how to reproduce or exercise this code path, so we'll have to wait for Rik to look at it, but it should at least not throw errors now.
abeatrix
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: 1988
It was throwing at least two exceptions, one reported by QA and one that I saw myself.
The one I saw was that
ProtocolTextDocumentmust be created on the EDT.Test plan
Tested manually.
I don't really know how to reproduce or exercise this code path, so we'll have to wait for Rik to look at it, but it should at least not throw errors now.
It definitely removed the exception I was seeing on startup, about needing the EDT.