Generated Protocol Bindings #1931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkukielka
reviewed
Jul 22, 2024
| // This is just a temporary solution to make it easier to use certain generated protocol | ||
| // messages. | ||
| // Ultimately this should entirely be replaced by use of the generated protocol. | ||
| if (!isForceProtocolCopy) { |
There was a problem hiding this comment.
What is the purpose of this flag if it needs to always be set for task to have any effect?
Shouldn't force be necessary only if the protocol files already exists? (is it even an option that no such files would be present)?
If that flag is always needed then equally good we can just not have it.
There was a problem hiding this comment.
I'll address this when we set up CI & automatic generation on builds etc. For now it's all manual while we iron out the wrinkles
pkukielka
approved these changes
Jul 22, 2024
mkondratek
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds generated protocol bindings for use in #1921
Test plan