Shut down agent after each test #1922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odisseus
changed the title
pkukielka
reviewed
Jul 22, 2024
src/integrationTest/kotlin/com/sourcegraph/cody/util/CodyIntegrationTextFixture.kt
Outdated
Show resolved
Hide resolved
pkukielka
reviewed
Jul 22, 2024
src/integrationTest/kotlin/com/sourcegraph/cody/util/CodyIntegrationTextFixture.kt
Outdated
Show resolved
Hide resolved
odisseus
force-pushed
the
odisseus-patch-1
branch
from
289a99e
to
c0117cf
Compare
odisseus
changed the title
odisseus
force-pushed
the
odisseus-patch-1
branch
from
c0117cf
to
6f2150d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
CodyIntegrationTextFixturestarts a fresh agent for every test case, we need to shut down those agents during cleanup. Otherwise the leftover agent processes clog the RAM (each Node process takes 50-250 MB), and the JVM threads which listen to them keep running forever.Test plan
Manually run the stability check in CI
1000 repetitions (5000 individual test cases): 2 hours 40 minutes, 118 failures