Skip to content

Commit

Permalink
Do not use separator() call directly (#330)
Browse files Browse the repository at this point in the history
## Test plan

<!-- All pull requests REQUIRE a test plan:
https://sourcegraph.com/docs/dev/background-information/testing_principles

Why does it matter?

These test plans are there to demonstrate that are following industry
standards which are important or critical for our customers.
They might be read by customers or an auditor. There are meant be simple
and easy to read. Simply explain what you did to ensure
your changes are correct!

Here are a non exhaustive list of test plan examples to help you:

- Making changes on a given feature or component:
- "Covered by existing tests" or "CI" for the shortest possible plan if
there is zero ambiguity
  - "Added new tests"
- "Manually tested" (if non trivial, share some output, logs, or
screenshot)
- Updating docs:
  - "previewed locally"
  - share a screenshot if you want to be thorough
- Updating deps, that would typically fail immediately in CI if
incorrect
  - "CI"
  - "locally tested"
-->
  • Loading branch information
pkukielka authored Jan 23, 2024
1 parent 7db492f commit e6c887b
Showing 1 changed file with 6 additions and 10 deletions.
16 changes: 6 additions & 10 deletions src/main/java/com/sourcegraph/cody/SubscriptionTabPanel.kt
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package com.sourcegraph.cody
import com.intellij.ide.BrowserUtil
import com.intellij.ide.ui.LafManagerListener
import com.intellij.ide.ui.laf.darcula.ui.DarculaButtonUI
import com.intellij.openapi.application.ApplicationInfo
import com.intellij.openapi.application.ApplicationManager
import com.intellij.ui.dsl.builder.panel
import com.intellij.util.ui.JBUI
Expand Down Expand Up @@ -54,15 +53,12 @@ class SubscriptionTabPanel : JPanel() {
"</tr>" +
"</table>")
}
if (ApplicationInfo.getInstance().build.baselineVersion < 223) {
separator()
} else {
row {
if (ThemeUtil.isDarkTheme()) {
text("<div style=\"height: 1px; background-color: #404245;\"></div>")
} else {
text("<div style=\"height: 1px; background-color: #ECEDF1;\"></div>")
}

row {
if (ThemeUtil.isDarkTheme()) {
text("<div style=\"height: 1px; background-color: #404245;\"></div>")
} else {
text("<div style=\"height: 1px; background-color: #ECEDF1;\"></div>")
}
}
}
Expand Down

0 comments on commit e6c887b

Please sign in to comment.