Fixes

sourcegraph · Jul 30, 2024 · e69f21d · e69f21d
1 parent 3fb7a82
commit e69f21d
Showing 1 changed file with 7 additions and 7 deletions.
diff --git a/src/main/kotlin/com/sourcegraph/cody/api/SourcegraphApiRequest.kt b/src/main/kotlin/com/sourcegraph/cody/api/SourcegraphApiRequest.kt
@@ -32,11 +32,6 @@ sealed class SourcegraphApiRequest<out T>(val url: String) {
           return SourcegraphApiContentHelper.toJson(request, true)
         }
 
-      private fun throwException(errors: List<GraphQLErrorDTO>): Nothing {
-        if (errors.size == 1) throw SourcegraphConfusingException(errors.single().toString())
-        throw SourcegraphConfusingException(errors.toString())
-      }
-
       override fun extractResult(response: SourcegraphApiResponse): T {
         val result: GraphQLResponseDTO<out T, GraphQLErrorDTO> =
             response.readBody {
@@ -52,8 +47,13 @@ sealed class SourcegraphApiRequest<out T>(val url: String) {
         if (data != null) return data
 
         val errors = result.errors
-        if (errors == null) error("Undefined request state - both result and errors are null")
-        else throwException(errors)
+        when {
+          errors == null ->
+              throw SourcegraphConfusingException(
+                  "Undefined request state - both result and errors are null")
+          errors.size == 1 -> throw SourcegraphConfusingException(errors.single().toString())
+          else -> throw SourcegraphConfusingException(errors.toString())
+        }
       }
     }
   }