Skip to content

Commit

Permalink
Drop post-sign-up survey which breaks in Sourcegraph experimental UI (#…
Browse files Browse the repository at this point in the history
…1938)

## Test plan

Manual test:

- Log in to Sourcegraph.com, flip the "experimental" mode on (top
right).
- Open JetBrains settings and sign out of all accounts.
- In the side bar, use the social buttons to sign in. You should be able
to sign in.
- Repeat the above test, but with the "experimental" mode off.
  • Loading branch information
dominiccooney authored Jul 23, 2024
1 parent dec3437 commit 37ddfa7
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,17 @@ internal class SourcegraphAuthService : AuthServiceBase() {
when (authMethod) {
SsoAuthMethod.GITHUB -> {
val end =
".auth/openidconnect/login?prompt_auth=github&pc=sams&redirect=/post-sign-up?returnTo=/user/settings/tokens/new/callback?requestFrom=JETBRAINS-$port"
".auth/openidconnect/login?prompt_auth=github&pc=sams&redirect=/user/settings/tokens/new/callback?requestFrom=JETBRAINS-$port"
Urls.newFromEncoded(ConfigUtil.DOTCOM_URL + end)
}
SsoAuthMethod.GITLAB -> {
val end =
".auth/openidconnect/login?prompt_auth=gitlab&pc=sams&redirect=/post-sign-up?returnTo=/user/settings/tokens/new/callback?requestFrom=JETBRAINS-$port"
".auth/openidconnect/login?prompt_auth=gitlab&pc=sams&redirect=/user/settings/tokens/new/callback?requestFrom=JETBRAINS-$port"
Urls.newFromEncoded(ConfigUtil.DOTCOM_URL + end)
}
SsoAuthMethod.GOOGLE -> {
val end =
".auth/openidconnect/login?prompt_auth=google&pc=sams&redirect=/post-sign-up?returnTo=/user/settings/tokens/new/callback?requestFrom=JETBRAINS-$port"
".auth/openidconnect/login?prompt_auth=google&pc=sams&redirect=/user/settings/tokens/new/callback?requestFrom=JETBRAINS-$port"
Urls.newFromEncoded(ConfigUtil.DOTCOM_URL + end)
}
else ->
Expand Down

0 comments on commit 37ddfa7

Please sign in to comment.