Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Commit

Permalink
Install all instead of ...
Browse files Browse the repository at this point in the history
go1.10 introduces the cache directory. So now objects will only appear in `pkg` if
they are explicitly installed. Previous versions of go would create entries for
the transitive dependencies. So for our vendor tests running `go install -i ...`
would not create a corresponding file in `pkg` for the vendored packages since
`...` does not list vendor. Using `all` instead does include the vendored pkg,
so will include the vendored pkgs. This will likely have wider effects on go
tooling that rely on pkg. Already filed nsf/gocode#500
for gocode.
  • Loading branch information
keegancsmith committed Feb 14, 2018
1 parent 3247dad commit db373e4
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions langserver/langserver_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1257,12 +1257,12 @@ func lspTests(t testing.TB, ctx context.Context, h *LangHandler, c *jsonrpc2.Con
// Install all Go packages in the $GOPATH.
oldGOPATH := os.Getenv("GOPATH")
os.Setenv("GOPATH", tmpDir)
out, err := exec.Command("go", "install", "-v", "...").CombinedOutput()
out, err := exec.Command("go", "install", "-v", "all").CombinedOutput()
os.Setenv("GOPATH", oldGOPATH)
if err != nil {
t.Fatal(err)
}
t.Logf("$ go install -v ...\n%s", out)
t.Logf("$ go install -v all\n%s", out)

testOSToVFSPath = func(osPath string) string {
return strings.TrimPrefix(osPath, util.UriToPath(util.PathToURI(tmpDir)))
Expand Down

0 comments on commit db373e4

Please sign in to comment.