Improve Cody logging agent protocol #6069
Merged
+40
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkondratek
reviewed
Nov 5, 2024
| @@ -530,32 +530,27 @@ export namespace UriString { | |||
| } | |||
|
|
|||
| function outputChannel(name: string): vscode.LogOutputChannel { | |||
| function notifyAgent(level: DebugMessageLogLevel, message: string, ...args: any[]): void { | |||
| if (agent) { | |||
There was a problem hiding this comment.
There is some contradiction in this method. It is called notifyAgent but we seem to check if we use agent inside of it.
maybe s/notifyAgent/notifyAgentIfApplicable/g?
no hard feelings about it tho. feel free to leave it as it is if it makes sense to you
There was a problem hiding this comment.
This check does not verify if we are in the 'agent' mode, it just check if agent object is already initialized.
vscode-shim.ts is used only for agent-related workflows.
mkondratek
approved these changes
Nov 5, 2024
We need, and they are regenerated :) /edit you are right, I missed to add one new class, fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes logging capability in agent.
Previously messages logged to output channel were visible only if added using
appendorappendLine.Now
trace/debug/info/warn/errorfunctions are also logged properly.Test plan
As in sourcegraph/jetbrains#2583