Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: Handle VSCode AMD -> ESM migration #5941

Open
wants to merge 2 commits into
base: rnauta/ci-enable-e2e-v2/wait-for-client-config
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions biome.jsonc
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,16 @@
}
}
},
{
"include": ["vscode/e2e/utils/vscody/uix/**/*.ts"],
"linter": {
"rules": {
"suspicious": {
"noExportsInTest": "off"
}
}
}
},
{
"include": ["**/*.test.ts"],
"linter": {
Expand Down
2 changes: 1 addition & 1 deletion lib/shared/src/test/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
* depending on other state the displayed value might change.
*/
export enum InvisibleStatusBarTag {
IsAuthenticated = '\u200B',
HasErrors = '\u200C',
HasLoaders = '\u200D',
IsIgnored = '\u2060',
IsAuthenticated = '\u2061',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Evidently \u2061 no longer unassigned

// Unassigned = '\u2061'
// Unassigned = '\u2062'
// Unassigned = '\u2063'
Expand Down
21 changes: 18 additions & 3 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pnpm-workspace.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ packages:
- lib/*
- vscode
- web
- vscode/e2e/utils/extension
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep sorted

Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,17 @@ log:
value: sourcegraph.com
- name: accept-encoding
value: identity
- name: user-agent
value: node-fetch/1.0 (+https://github.com/bitinn/node-fetch)
- name: content-length
value: "101"
- name: accept
value: "*/*"
- name: user-agent
value: vscode/1.38.1 (Node.js v20.16.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this relevant to this patch? Why did the user agent change if we are just changing some imports?

- name: content-type
value: application/json; charset=utf-8
- name: x-mitm-proxy-name
value: sourcegraph.dotcom
headersSize: 493
headersSize: 471
httpVersion: HTTP/1.1
method: POST
postData:
Expand All @@ -52,12 +52,12 @@ log:
content:
mimeType: application/json
size: 73
text: "{\"data\":{\"site\":{\"productVersion\":\"293000_2024-09-30_5.7-c38beb7e\
16fb\"}}}"
text: "{\"data\":{\"site\":{\"productVersion\":\"295908_2024-10-17_5.8-bb4c7d4f\
356f\"}}}"
cookies: []
headers:
- name: date
value: Mon, 30 Sep 2024 23:45:25 GMT
value: Thu, 17 Oct 2024 16:07:38 GMT
- name: content-type
value: application/json
- name: content-length
Expand Down Expand Up @@ -86,15 +86,15 @@ log:
redirectURL: ""
status: 200
statusText: OK
startedDateTime: 2024-09-30T23:45:24.766Z
time: 266
startedDateTime: 2024-10-17T16:07:38.628Z
time: 228
timings:
blocked: -1
connect: -1
dns: -1
receive: 0
send: 0
ssl: -1
wait: 266
wait: 228
pages: []
version: "1.2"
Loading
Loading