Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add globalStorage/didChange agent endpoint #5795

Closed

Conversation

pkukielka
Copy link
Contributor

Test plan

N/A. It will be needed for sourcegraph/jetbrains#2382

Protocol files need to be regenerated but this have to be fixed and merged first.

this.db.set(key, value)
if (this.agent) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not do it this way. VSCode globalState is shared, and there's no notifications when other agents are editing it. We should build the notification we need at the semantic level in the extension and use that, instead of exciting some action every time global state changes.

What specifically are we using this for on the JetBrains side?

Copy link
Contributor

@dominiccooney dominiccooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to build the notification we need at the semantic level, instead of adding a notification on global state writes. Global state doesn't have this kind of notification for other concurrent editors, and I doubt we need notice every time someone writes anything into global state.

@pkukielka pkukielka closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants