Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify artificial delay logic and remove user-based latency #5622

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

arafatkatze
Copy link
Contributor

@arafatkatze arafatkatze commented Sep 18, 2024

Solves Linear Issue

History:

When working on the Removal of Artificial Latency behind a feature flag Valery said FeatureFlag.CodyAutocompleteUserLatency feature flag and all the related logic is not used anymore and plan on conducting no further experiments with it. So I removed that and a lot of related logic that made this function and its tests very intricate.

This PR does

  • Remove user-based latency adjustments and related feature flag
  • Simplify getArtificialDelay function to only consider language and completion intent
  • Update lowPerformanceConfig to include both language IDs and completion intents
  • Remove resetArtificialDelay function and related calls(This function would reset User based latency for when completions were rejected. This stuff is not relevant after the removal of the feature flag)
  • Update tests to reflect new simplified logic
  • Remove unused LatencyFeatureFlags interface and related parameters

Test plan

Added new tests and made the logic very clean and self explainatory.

Changelog

@arafatkatze arafatkatze changed the title Deleting Token Remove Latency Flag Sep 18, 2024
@arafatkatze arafatkatze force-pushed the remove-latency-flag branch 2 times, most recently from 9b3de4b to 909d658 Compare September 25, 2024 10:33
@arafatkatze arafatkatze marked this pull request as ready for review September 25, 2024 10:34
@arafatkatze arafatkatze changed the title Remove Latency Flag Remove cody-autocomplete-user-latency Flag Sep 26, 2024
@arafatkatze arafatkatze changed the title Remove cody-autocomplete-user-latency Flag simplify artificial delay logic and remove user-based latency Sep 26, 2024
@arafatkatze arafatkatze changed the title simplify artificial delay logic and remove user-based latency Simplify artificial delay logic and remove user-based latency Sep 26, 2024
@arafatkatze arafatkatze merged commit 1a5fdf0 into main Oct 1, 2024
18 checks passed
@arafatkatze arafatkatze deleted the remove-latency-flag branch October 1, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants